1) "brctl show" has no parameters.

2) Add a -n flag to iptables -L to skip DNS lookups

diff --git a/tools/examples/vif-bridge b/tools/examples/vif-bridge
index 7c8219b9ca1be2ee2945c707aa55b9319ad6f918..a4f6bb0e7fb83c197db22234a25dfc493921ea0c 100755 (executable)
--- a/tools/examples/vif-bridge
+++ b/tools/examples/vif-bridge
@@ -48,9 +48,9 @@ fi
 
 case "$command" in
     online)
-        if brctl show "$bridge" | grep "$vif" >&/dev/null
+        if brctl show | grep "$vif" >&/dev/null
         then
-          log debug "$vif already attached to $bridge"
+          log debug "$vif already attached to a bridge"
           exit 0
         fi
 

diff --git a/tools/examples/vif-common.sh b/tools/examples/vif-common.sh
index f19a9790ff6a81e2393a5c92c73dbca876597236..a8750f94b42c4b5c474e3dda326f647b2dadcc27 100644 (file)
--- a/tools/examples/vif-common.sh
+++ b/tools/examples/vif-common.sh
@@ -82,7 +82,7 @@ function handle_iptable()
   # binary is not sufficient, because the user may not have the appropriate
   # modules installed.  If iptables is not working, then there's no need to do
   # anything with it, so we can just return.
-  if ! iptables -L >&/dev/null
+  if ! iptables -L -n >&/dev/null
   then
     return
   fi